Summary

• Add the public TopKTopPSampler base API in src/base/top_k_top_p_sampler.h.
• Add an Ascend ACLNN implementation in src/native/ascend/ops/top_k_top_p_sampler/kernel.h.
• Add focused Ascend tests in tests/test_top_k_top_p_sampler.py.
• Keep the branch rebased onto current upstream master (d67759e).

Motivation

N/A. No issue is linked.

This adds a logits-level Ascend sampler boundary needed by inference pipelines that already prepare top-k and top-p controls outside InfiniOps.

Type of Change

• feat - new feature / new operator / new platform
• fix - bug fix
• perf - performance improvement (no behavioral change)
• refactor - code restructuring without behavior change
• test - adding or fixing tests only
• docs - documentation only
• build / ci - build system or CI configuration
• chore - tooling, formatting, or other non-code changes
• Breaking change (requires a ! in the Conventional Commits prefix or a BREAKING CHANGE: footer)

Platforms Affected

• CPU (WITH_CPU)
• NVIDIA (WITH_NVIDIA)
• Iluvatar (WITH_ILUVATAR)
• MetaX (WITH_METAX)
• Cambricon (WITH_CAMBRICON)
• Moore (WITH_MOORE)
• Ascend (WITH_ASCEND)
• PyTorch C++ bindings (WITH_TORCH)
• Build system / CMake / CI
• Python bindings / user-facing API

Test Results on Supported Platforms

git diff --check upstream/master...HEAD
clang-format --dry-run --Werror src/base/top_k_top_p_sampler.h src/native/ascend/ops/top_k_top_p_sampler/kernel.h
ruff format --check tests/test_top_k_top_p_sampler.py
ruff check tests/test_top_k_top_p_sampler.py

Head SHA: 5e36a1d029c8cd3695cdb60bf8190dc5a9f25f22
Base SHA: d67759e0c59de09087a4e8774c8a5f4db7bd5134
Triggered at: 2026-06-30 06:11 UTC
Status at description update: ruff and matrix generation passed; clang-format in progress; platform unit jobs queued.

Benchmark / Performance Impact

N/A. This PR adds a correctness-tested operator wrapper and does not include a performance benchmark.

Notes for Reviewers

API alignment note:

• Reference checked: vLLM vllm.v1.sample.ops.topk_topp_sampler.TopKTopPSampler, whose native path receives logits, generators, k, and p, applies top-k/top-p filtering, and samples from logits.
• InfiniOps base signature: TopKTopPSampler(logits, k, p, out) and operator()(logits, k, p, out).
• Intentional deviations: InfiniOps uses an output tensor instead of returning sampled ids, does not expose Python generators, and does not return processed logits/logprobs. Temperature scaling remains caller-owned.
• Current Ascend ACLNN implementation is verified for the deterministic top_k == 1 subset; broader stochastic sampling is left out of this minimal PR.

Checklist

Title, Branch, and Commits

• PR title follows Conventional Commits.
• Branch name follows <type>/xxx-yyyy-zzzz.
• Each commit message follows Conventional Commits.
• Small PR is a single squashable commit.
• No stray merge commits from master.
• No fixup! / squash! / wip commits remain.

Scope and Design

• Changes are minimal.
• No dead code, commented-out blocks, debug prints, or ownerless TODO entries.
• No unrelated formatting churn.
• Public API changes are intentional, documented, and reflected in tests.

General Code Hygiene

• The code is self-explanatory; comments were added only where the reason is non-obvious.
• Every modified or added file ends with a single trailing newline.
• No trailing whitespace, tab/space mixing, or stray BOMs.
• Identifiers in comments and error messages are wrapped in backticks.
• All comments and error messages are in English.
• Comments and error messages are complete sentences unless the language/framework convention says otherwise.

C++ Specific

• Code follows the Google C++ style used in this repository.
• clang-format --dry-run --Werror src/base/top_k_top_p_sampler.h src/native/ascend/ops/top_k_top_p_sampler/kernel.h passes.
• Operator parameter order is inputs, attributes, outputs.
• No exceptions are thrown.
• Error message wording was reviewed.
• Kernel and kernel launcher separation does not apply to this ACLNN wrapper header.
• Constructor initializer list order matches member declaration order.
• Blank line rules were reviewed.
• New operator follows the src/base/<op>.h plus src/native/ascend/ops/<op>/ pattern.
• No raw new / delete.

Python Specific

• ruff format --check tests/test_top_k_top_p_sampler.py passes.
• ruff check tests/test_top_k_top_p_sampler.py passes.
• Framework-specific conventions are honored where applicable.
• Function body spacing follows the project Python rules.

Testing

• GitHub CI re-run was triggered by updating the PR branch.
• New functionality has matching tests under tests/.
• Tests use pytest.mark.parametrize and pytest.mark.auto_act_and_assert.
• Default device parameterization is used.
• N/A: No bug fix regression test is needed for this feature PR.

Build, CI, and Tooling

• git diff --check passes.
• No new runtime dependency was added.
• No CMake or CI configuration changes remain in this PR.

Documentation

• N/A: README.md / CONTRIBUTING.md changes are not needed for this small operator addition.
• New public operator behavior is documented in the base header and tests.
• N/A: No user-visible breaking change.

Security and Safety

• No secrets, access tokens, internal URLs, customer data, or personal hardware identifiers have been committed.
• No third-party code was added.
• No unsafe pointer arithmetic, uninitialized reads, or missing bounds checks were introduced.